Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up WORKSPACE. #105

Merged
merged 8 commits into from
Dec 6, 2020
Merged

Conversation

mathetake
Copy link
Contributor

@mathetake mathetake commented Nov 22, 2020

Clean up WORKSPACE file:

  • move all http_archives to bazel/repositories.bzl
  • stop using git_repository for protobuf and proxy_wasm_cpp_sdk
  • update cpp_sdk to the latest
  • move test/test_data/wasm.bzl to bazel/wasm.bzl

Signed-off-by: mathetake [email protected]

Signed-off-by: mathetake <[email protected]>
bazel/dependencies_extra.bzl Outdated Show resolved Hide resolved
Signed-off-by: mathetake <[email protected]>
@mathetake mathetake requested a review from PiotrSikora December 4, 2020 07:23
@PiotrSikora
Copy link
Member

Looks like rules_rust update resulted in a real issue:

warning: unused variable: `val`
  --> test/test_data/trap.rs:20:28
   |
20 | pub extern "C" fn trigger2(val: i32) -> i32 {
   |                            ^^^ help: if this is intentional, prefix it with an underscore: `_val`
   |
   = note: `#[warn(unused_variables)]` on by default

Could you fix that?

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I have slight preference for repositories and dependencies instead of dependencies and dependencies_extra.

@mathetake mathetake requested a review from PiotrSikora December 6, 2020 12:27
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit bf2cfca into proxy-wasm:master Dec 6, 2020
@mathetake mathetake deleted the clean-workspace-file branch December 6, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants