Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libc (transitive dependency) to v0.2.90. #95

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora PiotrSikora requested a review from mathetake March 19, 2021 01:39
Copy link

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'm wondering if we could automate the transitive dependency update? e.g. adding scheduled github action to create PRs like this)

@PiotrSikora PiotrSikora merged commit 5254f07 into proxy-wasm:master Mar 19, 2021
@PiotrSikora
Copy link
Member Author

LGTM (I'm wondering if we could automate the transitive dependency update? e.g. adding scheduled github action to create PRs like this)

We could... Alternatively, we could ignore transitive dependencies, since we need them only for Bazel builds (we don't ship Cargo.lock, so Cargo builds are always using the latest versions), and even then, most of them are used only in examples:

$ cargo tree --target=wasm32-wasi --edges normal
proxy-wasm v0.1.3 (/path/to/proxy-wasm-rust-sdk)
├── hashbrown v0.11.0
│   └── ahash v0.7.2
│       ├── getrandom v0.2.2
│       │   ├── cfg-if v1.0.0
│       │   └── wasi v0.10.2+wasi-snapshot-preview1
│       └── once_cell v1.7.2
└── log v0.4.14
    └── cfg-if v1.0.0

@PiotrSikora
Copy link
Member Author

LGTM (I'm wondering if we could automate the transitive dependency update? e.g. adding scheduled github action to create PRs like this)

We could... Alternatively, we could ignore transitive dependencies, since we need them only for Bazel builds (we don't ship Cargo.lock, so Cargo builds are always using the latest versions), and even then, most of them are used only in examples:

$ cargo tree --target=wasm32-wasi --edges normal
proxy-wasm v0.1.3 (/path/to/proxy-wasm-rust-sdk)
├── hashbrown v0.11.0
│   └── ahash v0.7.2
│       ├── getrandom v0.2.2
│       │   ├── cfg-if v1.0.0
│       │   └── wasi v0.10.2+wasi-snapshot-preview1
│       └── once_cell v1.7.2
└── log v0.4.14
    └── cfg-if v1.0.0

@mathetake any thoughts on this?

@mathetake
Copy link

Sorry forgot to reply. If we could assume that majority of users would use cargo, not Basel, then let’s ignore the transitive dependencies upgrades.

@codefromthecrypt
Copy link

I agree. the bazel part is distracting and personally not helpful even if some like it.

@PiotrSikora
Copy link
Member Author

@codefromthecrypt yup, the freshness check was removed in #99, and I'm going to update Bazel deps only before creating a new release.

nullpo-head pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
nullpo-head pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants