-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libc (transitive dependency) to v0.2.90. #95
Conversation
Signed-off-by: Piotr Sikora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I'm wondering if we could automate the transitive dependency update? e.g. adding scheduled github action to create PRs like this)
We could... Alternatively, we could ignore transitive dependencies, since we need them only for Bazel builds (we don't ship
|
@mathetake any thoughts on this? |
Sorry forgot to reply. If we could assume that majority of users would use cargo, not Basel, then let’s ignore the transitive dependencies upgrades. |
I agree. the bazel part is distracting and personally not helpful even if some like it. |
@codefromthecrypt yup, the freshness check was removed in #99, and I'm going to update Bazel deps only before creating a new release. |
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora [email protected]