Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upsampling misalignments after resizing #63

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions marigold/util/image_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ def resize_max_res(
img: torch.Tensor,
max_edge_resolution: int,
resample_method: InterpolationMode = InterpolationMode.BILINEAR,
div8=False,
) -> torch.Tensor:
"""
Resize image to limit maximum edge length while keeping aspect ratio.
Expand All @@ -104,6 +105,12 @@ def resize_max_res(
new_width = int(original_width * downscale_factor)
new_height = int(original_height * downscale_factor)

# round it up or down to the next multiple of 8
# to avoid upsampling misalignments due to smaller latent dimension
if div8:
new_width = round(new_width / 8) * 8
new_height = round(new_height / 8) * 8

resized_img = resize(img, (new_height, new_width), resample_method, antialias=True)
return resized_img

Expand Down
Loading