Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to React native 0.63.2 and typescript #141

Merged
merged 2 commits into from
Sep 13, 2020
Merged

Migrate to React native 0.63.2 and typescript #141

merged 2 commits into from
Sep 13, 2020

Conversation

AliRezaBeigy
Copy link
Contributor

Migrate Example to React native 0.63.2
Migrate to typescript
Update gitignore
Fix crash index not found
Remove useless condition to hidden controls

Add TypeScript
Update gitignore
Fix crash index not found
Remove useless condition to hidden controls
@prscX prscX self-assigned this Sep 13, 2020
@prscX
Copy link
Owner

prscX commented Sep 13, 2020

Thanks @AliRezaBeigy for all the efforts you have added.

I have merged the PR. Post validate, I will push the release.

Thanks
</ Pranav >

@prscX prscX merged commit f73375b into prscX:master Sep 13, 2020
@prscX
Copy link
Owner

prscX commented Sep 13, 2020

@AliRezaBeigy: I have pushed the release - 1.0.7.

Please follow updated installation steps defined in README. Let me know incase you face any issues.

Thanks
</ Pranav >

@AliRezaBeigy
Copy link
Contributor Author

AliRezaBeigy commented Sep 13, 2020

https://github.com/prscX/react-native-photo-editor#-usage
this part should update to the following code:

import PhotoEditor from 'react-native-photo-editor'

PhotoEditor.Edit({
    path: RNFS.DocumentDirectoryPath + "/photo.jpg"
});

@AliRezaBeigy
Copy link
Contributor Author

@prscX
I have the following error on mac:

yarn install v1.22.4
warning package.json: License should be a valid SPDX license expression
info No lockfile found.
warning [email protected]: License should be a valid SPDX license expression
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@>= 4.12.1".
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@>=3.14.1".
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@>= 5.0.0".
warning "prettier-pack > [email protected]" has unmet peer dependency "prettier@>= 1.13.0".
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@>=4.0.0".
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0".
warning "prettier-pack > [email protected]" has unmet peer dependency "eslint@>=6.1.0".
warning "prettier-pack > [email protected]" has unmet peer dependency "[email protected] - 6.x".
[4/4] 🔨  Building fresh packages...
[-/4] ⠁ waiting...
[4/4] ⠁ prettier-pack
[-/4] ⠁ waiting...
error /Users/arb/IdeaProjects/react-native-photo-editor/node_modules/prettier-pack: Command failed.
Exit code: 127
Command: node script.js && code --install-extension dbaeumer.vscode-eslint && code --install-extension esbenp.prettier-vscode
Arguments: 
Directory: /Users/arb/IdeaProjects/react-native-photo-editor/node_modules/prettier-pack

@prscX
Copy link
Owner

prscX commented Sep 13, 2020

Got you. I will look into this and update you.

Thanks

@AliRezaBeigy
Copy link
Contributor Author

@prscX In README Add 'RNRichText' to the static framework in podfile

@AliRezaBeigy
Copy link
Contributor Author

And also remove @type/react from devDependency for the library

@prscX
Copy link
Owner

prscX commented Sep 14, 2020

@AliRezaBeigy: I have pushed a new release [V1.0.8]. Could you please install and verify.

I have removed RNRichText from Example, it was by mistake and not needed.

Thanks
</ Pranav >

@AliRezaBeigy
Copy link
Contributor Author

@prscX: everything looks ok in ios and android, now just should update ReadMe as I said in this comment

@prscX
Copy link
Owner

prscX commented Sep 15, 2020

Done, Thanks.

TimMun pushed a commit to TimMun/react-native-photo-editor that referenced this pull request Sep 8, 2021
Migrate to React native 0.63.2 and typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants