Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in "[CP] Copy Pods Resources" #170

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fix Error in "[CP] Copy Pods Resources" #170

merged 2 commits into from
Jan 26, 2021

Conversation

AliRezaBeigy
Copy link
Contributor

@AliRezaBeigy AliRezaBeigy commented Jan 20, 2021

Fix following issue:
#149

Pass path to onDone event(I'm very astonished at how this library was used for IOS)

Update README:
Remove Target:: for cocoapods >= 1.9.0

@prscX
Copy link
Owner

prscX commented Jan 22, 2021

Thanks @AliRezaBeigy raising the PR and Effort.

If looks good, one doubt I have: In below snippet, we don't need to send file path, since it will automatically modify and save the changes to same file:

_onDoneEditing(@[path]);

Thanks
</ Pranav >

@AliRezaBeigy
Copy link
Contributor Author

Thanks for your attention and fast response

Although it works as you mentioned in the ios platform but the code functionality needs to remain the same on both platforms. I found it confusing at first and it takes me time to figure it out. So I think it's better to return the paths in terms of unique functionality in both platforms

@prscX
Copy link
Owner

prscX commented Jan 26, 2021

Thanks for your response. I have merged the same.

Thanks
</ Pranav >

@prscX prscX merged commit cbbc08e into prscX:master Jan 26, 2021
@prscX
Copy link
Owner

prscX commented Jan 26, 2021

@AliRezaBeigy: I have pushed the release. Let me know if you face any issues.

Thanks
</ Pranav >

TimMun pushed a commit to TimMun/react-native-photo-editor that referenced this pull request Sep 8, 2021
Fix Error in "[CP] Copy Pods Resources"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants