Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M300 - play sound -> does not work #334

Closed
OndraCerv opened this issue Mar 31, 2020 · 14 comments
Closed

M300 - play sound -> does not work #334

OndraCerv opened this issue Mar 31, 2020 · 14 comments
Labels
bug Something isn't working. duplicate This issue or pull request already exists. feature request A request for adding a specific feature of change of behaviour.

Comments

@OndraCerv
Copy link

Hi,

Code M300 not play sound.
Please of implementacion into new firmware.

Thanks

@JohnnyDeer JohnnyDeer added the feature request A request for adding a specific feature of change of behaviour. label May 5, 2020
@hawwwran
Copy link
Contributor

hawwwran commented Jul 1, 2020

Yes, this!

@matthewlloyd
Copy link

Anyone following this issue may be interested to know that I just released custom firmware that adds support for M300 (play a sound), amongst other goodies:

http://github.com/matthewlloyd/Llama-Mini-Firmware#readme

@fortinmike
Copy link

@matthewlloyd Did you consider submitting your changes as pull requests to the original repo? Many (including me) are not interested in installing custom firmware but would still love to see some of the things you implemented built in.

@matthewlloyd
Copy link

Did you consider submitting your changes as pull requests to the original repo? Many (including me) are not interested in installing custom firmware but would still love to see some of the things you implemented built in.

Given that Prusa has, to my knowledge, never accepted a pull request to this repo, apart from ones written by members of the Prusa team, I considered that approach to be impractical. Besides, they are IMHO violating Marlin's GPL by not releasing the source code for the bootloader, and I am not inclined to contribute to their open source efforts until they have addressed that issue.

If you dislike how difficult Prusa has made it to install custom firmware, I recommend getting in touch with Prusa directly to let your feelings about the appendix be known.

Meanwhile, you can always purchase a clone Mini or Buddy board, and run whatever firmware suits you on it.

@fortinmike
Copy link

Given that Prusa has, to my knowledge, never accepted a pull request to this repo, apart from ones written by members of the Prusa team

I was not aware of that. Are you sure that absolutely no pull request was ever accepted? Did they just ignore them or did they at least give a reasonable reason for refusing to merge? That's a bummer for sure. Still, maybe having pull requests sitting on GitHub might pressure them a bit and possibly help kickstart (possibly internal) development on specific features?

As for the appendix on the Buddy board, seems reasonable to me that they have some kind of way to know if, for example, you broke/bricked your machine because you installed defective, unsupported firmware on it. In the end they pay people to support users and IMHO it's not their job to fix issues you create yourself with modifications. Plus breaking the appendix only voids the warranty on the electronics instead of the whole machine. In essence, for sure no appendix would be better, but the fact that it exists does not bother me much, personally. On the other side of the coin, having a hardware mechanism that ensures only signed firmware is installed is a nice security feature to have.

To me, it's still incredible for a for-profit company to release all of their hardware and software as open source and allow flashing custom firmware, with documentation on how to do it to boot, even if it's not perfect.

As for the bootloader, how do people make MINI clones without access to it?

@foorschtbar
Copy link
Contributor

+1

@Eldenroot
Copy link

Any progress?

@Gordontgopher
Copy link

M300 is enabled in 4.3.4 but there are reports that it is buggy (#1075 (comment))

@Eldenroot
Copy link

I use 4.4.0 firmware.

M300 works fine at least for G-code start.

Not working for G-code end properly...

I just use basic tones... so maybe it is bugged.

Would be really cool to fix this issue, even low cost Chinese printers can do that :)

@Prusa-Support Prusa-Support added bug Something isn't working. 4.4.0 labels Jan 5, 2023
@Prusa-Support
Copy link
Collaborator

Pull Requests about M300 functionality were merged in January 2022 (#1796, #1800), supposedly only after the FW 4.3.4 final release (December 2021).

Same as #1075, thanks for reporting this.

Michele Moramarco
Prusa Research

@bcolledge04
Copy link

Any update/progress on this ?

@Prusa-Support
Copy link
Collaborator

No news. I'm sorry, FW 4.4.1 was released shortly after the last few messages.
I'm afraid this issue didn't make it to the last firmware release.

Michele Moramarco
Prusa Research

Copy link

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@danopernis
Copy link
Member

Let me close this as a duplicate of #3660 although this issue is certainly older. The fix is scheduled for next patch release. Sorry for all the confusion.

@danopernis danopernis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
@danopernis danopernis added the duplicate This issue or pull request already exists. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. duplicate This issue or pull request already exists. feature request A request for adding a specific feature of change of behaviour.
Projects
None yet
Development

No branches or pull requests