Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFW-5083] [BUG] GCode sound playback (M300) is to fast!? #3660

Closed
foorschtbar opened this issue Jan 4, 2024 · 6 comments
Closed

[BFW-5083] [BUG] GCode sound playback (M300) is to fast!? #3660

foorschtbar opened this issue Jan 4, 2024 · 6 comments
Assignees
Labels
bug Something isn't working.

Comments

@foorschtbar
Copy link
Contributor

foorschtbar commented Jan 4, 2024

Printer type MK4

Printer firmware version 5.1.2

Original or Custom firmware - Original

Optional upgrades n/a

USB drive or USB/Octoprint Octoprint

Describe the bug
Since a few weeks we got M300 GCode support, but the playback seams to fast

How to reproduce
Try this gcodes:

;Scooter
M300 S1567 P206
M300 S1567 P206
M300 S1396 P103
M300 S1318 P103
M300 S1396 P413
M300 S1174 P310
M300 S1046 P103
M300 S1174 P206
M300 S1567 P206
M300 S1567 P206
M300 S1396 P206
M300 S1318 P206
M300 S1567 P206
M300 S1567 P206
M300 S1396 P103
M300 S1318 P103
M300 S1396 P413
M300 S1174 P413
M300 S1318 P206
M300 S1046 P206
M300 S1174 P827
M300 S0 P206

Expected behavior

@foorschtbar foorschtbar added the bug Something isn't working. label Jan 4, 2024
@bkerler
Copy link
Contributor

bkerler commented Jan 13, 2024

Not 100% sure, but I think it's related to this line : here.

        per = (uint32_t)(1'000.0F / frq);
        pul = (uint32_t)(del / per);

I don't see any relation between del (delay) and the hw clock frequency, but maybe I'm missing something.

@bkerler
Copy link
Contributor

bkerler commented Jan 15, 2024

I just pushed a PR that should fix the issue.

@CZDanol
Copy link
Contributor

CZDanol commented Feb 15, 2024

Internal ticket number: BFW-5083

@danopernis danopernis added the scheduled We are working on it or we have scheduled it for one of the next releases. label Apr 30, 2024
@Prusa-Support
Copy link
Collaborator

The fix was merged at the end of April and made available with the firmware release in May, so that adding a Dwell code is no longer needed.

This should close this issue, however, further feedback is surely welcome.

Michele Moramarco
Prusa Research

@CZDanol CZDanol changed the title [BUG] GCode sound playback (M300) is to fast!? [BFW-5083] [BUG] GCode sound playback (M300) is to fast!? Jun 23, 2024
@CZDanol CZDanol changed the title [BFW-5083] [BUG] GCode sound playback (M300) is to fast!? [BFW-5083][BUG] GCode sound playback (M300) is to fast!? Jun 23, 2024
@CZDanol CZDanol changed the title [BFW-5083][BUG] GCode sound playback (M300) is to fast!? [BFW-5083] [BUG] GCode sound playback (M300) is to fast!? Jun 23, 2024
@danopernis
Copy link
Member

There must have been some misunderstanding. This was merged, but not released. It is scheduled for the next patch version. Sorry for the confusion.

@danopernis
Copy link
Member

New firmware v6.0.4 was just released which should fix this.

@danopernis danopernis removed the scheduled We are working on it or we have scheduled it for one of the next releases. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

5 participants