[BFW-5432] gcode: Add mk3 compatibility to G90 command #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkerler
force-pushed
the
g90_mk3_compat
branch
2 times, most recently
from
e968900 to
3466d70
Compare
|
This mixes actual code changes with formatting changes and is quite difficult to review. It sill also be more difficult to merge. Can you please rework this so the change is minimal? |
|
@danopernis Sorry, seems like clang-format automatically changed the whole file. It's now modded to only reflect the change. |
danopernis
force-pushed
the
g90_mk3_compat
branch
2 times, most recently
from
3093263 to
c2bb480
Compare
danopernis
force-pushed
the
g90_mk3_compat
branch
from
c2bb480 to
039a891
Compare
danopernis
approved these changes
Apr 29, 2024
danopernis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #3847.
When in mk3 compatibility mode, the G90 command should behave exactly as in https://github.com/prusa3d/Prusa-Firmware/blob/MK3/Firmware/Marlin_main.cpp#L5120.
However the MK4 normally does also set absolute values for the E-Axis, which the MK3 didn't do before (which is also documented), as you can see here:
https://github.com/prusa3d/Prusa-Firmware-Buddy/blob/master/lib/Marlin/Marlin/src/gcode/gcode.h#L314
This PR adds further support for the MK3 compatibility mode by removing setting absolute values for the E-Axis for gcode G90.