selftest: BUG 3480: Fix inconsistent failures on XL Fan Test #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the max on the XL print fan speed. Several users pushing over 6799 RPM causing failure, me included. The print fan and heatbreak fan appear to be linked with an assertion which is unfortunate because I can certainly confirm that in my case the maximum on the print fan is insufficient and requires disassembly of the print shroud to pass which is inconvenient.
Because of the assertion, I only increased by 100 RPM - but there are reports in the wild, especially in high altitude situations, of the fans going over 7,000 RPM with the shroud in place.
The assertion appears to be in place so that the "fans switched" check works correctly... but this may need to further be updated to only raise a message if the reports are outside of a specific range where this is a sure conclusion - because the appropriate value for the print fan should probably be increased to 7k+ RPM to compensate for shroud and altitude which would certainly overlap the minimum for the heatbreak. Will perform some more testing to get some realistic values.
For now, I am just trying to correct this for a majority of users I have seen in the wild, who are only slightly exceeding the print fan maximum.