Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SELFTEST-BUG 3480/BFW-5677. Allowable overlap range on Switched Fan Detection. #4256

Closed
wants to merge 1 commit into from

Conversation

deniolan
Copy link

Allowing for an overlap range on Fan Check to allow for the fact that sometimes switched fan detection is not possible, and on XL's this happens quite frequently. The hot ends also come preassembled, so this alleviates the annoyance of having to remove the shroud just to do initial calibration or a factory reset, while still allowing for switched fan detection when ranges permit.

This addresses #3480

… sometimes switched fan detection is not possible, and on XL's this happens quite frequently. The hot ends also come preassembled, so this alleviates the annoyance of having to remove the shroud just to do initial calibration or a factory reset, while still allowing for switched fan detection when ranges permit.
@deniolan deniolan closed this Oct 16, 2024
@deniolan
Copy link
Author

Can't load Holly to see what is going on - will try again later.

@Tomcus
Copy link
Contributor

Tomcus commented Oct 16, 2024

@deniolan it is failing on format check. Make sure you have pre-commit installed on your system and that it is registered as a hook in your local repo.

@deniolan
Copy link
Author

@deniolan it is failing on format check. Make sure you have pre-commit installed on your system and that it is registered as a hook in your local repo.

Thanks - any idea why I was getting a block page on holly? Seemed to be an invalid certificate at least from what I could tell… Got a Prusa block page telling me to use a VPN to view it.

Thanks!

@Tomcus
Copy link
Contributor

Tomcus commented Oct 16, 2024

@deniolan it is failing on format check. Make sure you have pre-commit installed on your system and that it is registered as a hook in your local repo.

Thanks - any idea why I was getting a block page on holly? Seemed to be an invalid certificate at least from what I could tell… Got a Prusa block page telling me to use a VPN to view it.

Thanks!

Yes, IT moved most of our internal services behind VPN. That includes Holly. IT knows, that public developers can't see Holly and they plan to somehow to fix/remedy this issue. But I don't know when and how is it going to work.

@deniolan
Copy link
Author

Thank you. I installed pre-commit and recreated the original commit/pull request. Looks like it is green now. Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants