Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of Print/Filament/Printer Settings not detected #8254

Closed
2 tasks
Gregor-Gregor opened this issue Apr 28, 2022 · 5 comments
Closed
2 tasks

Change of Print/Filament/Printer Settings not detected #8254

Gregor-Gregor opened this issue Apr 28, 2022 · 5 comments

Comments

@Gregor-Gregor
Copy link

Description of the bug

ISSUE:
While changing the value in any of the Settings tabs manually (i.e. writing the value in the textbox) and not confirming it by hitting enter/tab (so: changing the focus to another input field), then coming back to the Plater tab, the change of the parameter value is not detected, so sliced project still shows the "Export G-code" as a next step.
PROPOSED SOLUTION:
Trigger settings change verification also after tab change, or even every keystroke in the input controls (however it may induce avalanche of slicing when auto-slicing enabled).

Project file & How to reproduce

REPRODUCTION:

  1. open a new project,
  2. add any geometry to have anything for slicing,
  3. slice it (the bottom-right button switches to "Export G-code"),
  4. switch to "Print Settings" tab,
  5. enter eg. "Perimeters" parameter input textbox,
  6. change the value entering it with keyboard, do not hit ENTER nor TAB keys (leave the cursor inside),
  7. click on "Plater" tab,
  8. see the bottom-right button stuck in "Export G-code"

Checklist of files included above

  • Project file
  • Screenshot

Version of PrusaSlicer

2.4.2+win64

Operating system

Windows 10 64bit

Printer model

mini+

@rtyr
Copy link
Collaborator

rtyr commented Apr 28, 2022

I was not able to reproduce the behaviour when I followed your reproduction steps.

@Gregor-Gregor
Copy link
Author

Hi, ok, here comes a short video. IMPORTANT! Changing the value in Perimeters do not hit ENTER nor TAB afterwards, just use a mouse to switch tabs back to "Plater". BTW: I've checked it on 2 different machines, behaves the same.

PrusaSlicer-2.4.2.based.on.Slic3r.2022-04-28.23-24-18.mp4

.

@rtyr
Copy link
Collaborator

rtyr commented Apr 28, 2022

I see, it only happens with experimental "Set settings tabs as menu items" enabled. That is why I wasn't able to reproduce it.

@Gregor-Gregor
Copy link
Author

Ah, indeed, it hadn't crossed my mind it might be an important detail.
A picture is worth a thousand words, a video - a million. ;)

@lukasmatena
Copy link
Collaborator

Fixed in 2.6.0-alpha2. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants