Implement SSZ Tree Hash Algorithm #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI failed due to change irrelevant to this PR. |
shared/ssz/README.md
Outdated
| @@ -23,6 +23,14 @@ type Decodable interface { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Hashable | |||
| A type is Hashable if it implements `HashSSZ()`. | |||
There was a problem hiding this comment.
Can we rename HashSSZ to TreeHashSSZ to be more explicit? since there's still a more general hashing function that could be used
shared/ssz/hash.go
Outdated
| HashSSZ() ([32]byte, error) | ||
| } | ||
|
|
||
| // Hash calculate tree-hash result for input value. |
There was a problem hiding this comment.
s/calculate/calculates and I think TreeHash is a better name here
houjieth
commented
Dec 31, 2018
shared/ssz/README.md
Outdated
| @@ -23,6 +23,14 @@ type Decodable interface { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Hashable | |||
| A type is Hashable if it implements `HashSSZ()`. | |||
shared/ssz/hash.go
Outdated
| HashSSZ() ([32]byte, error) | ||
| } | ||
|
|
||
| // Hash calculate tree-hash result for input value. |
terencechain
approved these changes
Dec 31, 2018
rauljordan
approved these changes
Jan 1, 2019
| return hasher, nil | ||
| } | ||
|
|
||
| func merkleHash(list [][]byte) ([]byte, error) { |
There was a problem hiding this comment.
Hey @houjieth can we have some more detailed comments of the internal logic at the top of this function for easier readability?
There was a problem hiding this comment.
Sure. Just added some comments.
There was a problem hiding this comment.
can you also add a link of the official spec?
There was a problem hiding this comment.
Yes. Just added the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #716
Description
Implement tree-hash defined by ssz.