feat: implement block_to_light_client_header
#14433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redidacove
suggested changes
Sep 8, 2024
Redidacove
suggested changes
Sep 10, 2024
rupam-04
commented
Sep 10, 2024
rkapka
reviewed
Sep 10, 2024
rkapka
reviewed
Sep 12, 2024
rkapka
reviewed
Sep 12, 2024
rkapka
approved these changes
Sep 12, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Sep 12, 2024
b5cfd0d
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR implements the
block_to_light_client_headerfunction from CL specs light clientfull-node.mdupto Deneb (not Electra as of now). This function is needed to update thecreateLightClientBootstrapXXXfunctions to use thedevbranch of CL specs. Currently they follow this implementationWhich issues(s) does this PR fix?
Partly addresses #12991
Other notes for review
Acknowledgements