SSZ support for light client updates #14505
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds SSZ support to light client updates.
attested_header
andfinalized_header
fields of updates are defined as aLightClientHeaderContainer
, which itself is defined usingoneof
. This results in a non-exported interface type being generated and our SSZ generation library cannot handle this.This PR resolves the above issue in the following way:
XXXInternal
type for eachXXX
update type. It has the same fields as the original type, but the type ofattested_header
andfinalized_header
is replaced bybytes
.attested_header
andfinalized_header
into their "SSZ-bytes" representation by callingMarshalSSZ
on these headers.Which issues(s) does this PR fix?
Part of #12991
Acknowledgements