Update spec test to v1.5.0-beta.0 #14788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
spectest-beta-0
branch
from
f863d4d to
77a60bc
Compare
saolyn
reviewed
Jan 10, 2025
| @@ -38,6 +38,7 @@ var placeholderFields = []string{ | |||
| "MAX_BLOB_COMMITMENTS_PER_BLOCK", // Compile time constant on BeaconBlockBodyDeneb.blob_kzg_commitments. | |||
| "MAX_BYTES_PER_TRANSACTION", // Used for ssz of EL transactions. Unused in Prysm. | |||
| "MAX_EXTRA_DATA_BYTES", // Compile time constant on ExecutionPayload.extra_data. | |||
| "MAX_PAYLOAD_SIZE", | |||
There was a problem hiding this comment.
Is this supposed to be here?
There was a problem hiding this comment.
Shouldn't we handle this? The field was renamed from GOSSIP_MAX_SIZE to MAX_PAYLOAD_SIZE
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought about this for a while. For background, this change is based on ethereum/consensus-specs#4045. @nisdas is handling this change entirely in his upcoming PR, so I think it makes more sense to let him manage it all at once, it might get messy for him. In this PR, he will need to remove the variable from the placeholder anyway, or the test will fail
terencechain
force-pushed
the
spectest-beta-0
branch
6 times, most recently
from
e2c6275 to
340248d
Compare
terencechain
force-pushed
the
spectest-beta-0
branch
from
340248d to
3a77b43
Compare
james-prysm
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.