-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bazel-go-ethereum fork, use upstream go-ethereum #9725
Conversation
Change to draft. Cross compile is broken on mac, need to test windows. |
Tested cross compiles On darwin
Same issue as rjeczalik/notify#196 |
Cross compile fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For github.com/ethereum/go-ethereum/crypto/sepc256k1
, is there anyway we can ensure that whenever we update our geth commit, our vendored dependency is always in sync with that commit ? Otherwise there is the possibility of the the dependency simply being out of date.
@nisdas I think we should consider applying patches to go_repository. This has been harder to maintain in the past but would be a safer check that sepc256k1 is the same code as upstream. I'll give this a try tomorrow and see how large the patch would be for sepc256k1. The root of the fix was to define a |
Still working on this. |
This reverts commit 2e8128f.
What type of PR is this?
Other
What does this PR do? Why is it needed?
We have been maintaining bazel-go-ethereum for some time. The root cause is that bazel build file generation doesn't understand how to reference c dependencies in subdirectories.
The solution I have implemented here is to commit a few go-ethereum c dependencies into the vendor folder.
I took a shortcut with the usb library. We don't use this in prysm at all and I was spinning tires trying to figure out the right combination of things to add to the build files.
So, the usb library is stripped to be disabled. This is the same behavior we've done in bazel-go-ethereum.
Which issues(s) does this PR fix?
This unblocks some desired behavior for the merge testing. #9716
Anyone can now drop in a replacement for go-ethereum and it should work without thinking about messy bazel stuff (unless the drop in has new exotic c/c++ deps). Example below.
Other notes for review
Resolves #5418