Fix usage of lockAPI #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2024
fjtrujy
commented
Apr 14, 2024
| @@ -81,7 +81,9 @@ subroutines are required for linking multi-threaded applications. | |||
|
|
|||
| /* dummy lock routines and static locks for single-threaded apps */ | |||
|
|
|||
| #ifndef __SINGLE_THREAD__ | |||
| #include <newlib.h> | |||
There was a problem hiding this comment.
You need to include newlib.h otherwise you don't have access to the defined macros like __SINGLE_THREAD__
fjtrujy
commented
Apr 14, 2024
| #ifndef __SINGLE_THREAD__ | ||
| #include <newlib.h> | ||
|
|
||
| #if defined(__SINGLE_THREAD__) |
There was a problem hiding this comment.
This is actually a bug.
These are the dummy implementation if user selected _RETARGETABLE_LOCKING but it is still a SINGLE_THREAD configuration.
fjtrujy
commented
Apr 14, 2024
| @@ -8,6 +8,7 @@ typedef struct __dirdesc { | |||
| char *dd_buf; /* buffer */ | |||
| int dd_len; /* buffer length */ | |||
| int dd_size; /* amount of data in buffer */ | |||
| void *dd_lock; /* lock */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have thread-safe operations for all the
newliboperations we have been required to do several PR:newlibps2toolchain-eeps2sdkThis PR skips the usage of the dummy lock API, letting us implement the specific one in the
ps2sdk/libcglue