fix: fallback to x11 gdk backend on error

[psadi]

workaround, fixes #12

[Samueru-sama]

The problem with this method is that the application will be relaunched for any error and not just the wayland error.

So this should only happen if we check that we are on a wayland session at least, iirc there is an env variable you can check to determine that.

[psadi]

❯ echo $WAYLAND_DISPLAY
wayland-0

should this be suffice, for x11 this should return null

[Samueru-sama]

I also don't think you need to use eval and just check if $? is greater than 0.

[Samueru-sama]

I would do something like this instead:

#!/usr/bin/env sh

HERE="$(dirname "$(readlink -f "$0")")"

export TERM=xterm-256color
export GHOSTTY_RESOURCES_DIR="${HERE}/usr/share/ghostty"

exec "${HERE}"/ld-linux-x86-64.so.2 --library-path "${HERE}"/usr/lib "${HERE}"/usr/bin/ghostty "$@"

if [ "$?" -gt 0 ] && [ -n "$WAYLAND_DISPLAY" ]; then
	export GDK_BACKEND=x11
	exec "${HERE}"/ld-linux-x86-64.so.2 --library-path "${HERE}"/usr/lib "${HERE}"/usr/bin/ghostty "$@"
fi

[psadi]

exec "${HERE}"/ld-linux-x86-64.so.2 --library-path "${HERE}"/usr/lib "${HERE}"/usr/bin/ghostty "$@"

if [ "$?" -gt 0 ] && [ -n "$WAYLAND_DISPLAY" ]; then
export GDK_BACKEND=x11
exec "${HERE}"/ld-linux-x86-64.so.2 --library-path "${HERE}"/usr/lib "${HERE}"/usr/bin/ghostty "$@"
fi

Agree with this approach, check my latest -- thought of avoiding the same command twice and reference it from an array for readability.

[Samueru-sama]

shouldn't this be -n "$WAYLAND_DISPLAY"?

also I don't think "${command[@]}" is posix, remember we are using sh and not bash

[psadi]

100% -- wasn't thinking of POSIX standards. Amended the suggestions :)

[Samueru-sama]

Btw the original person that made the issue said this:

after the error a blank window opens up for a second or 2 then it quickly closes

So none of this is ideal, because on wayland people will see the window open for 2 seconds, then close and finally open again. every time they launch the appimage

we would need to create a file to indicate that wayland failed and check at runtime and all of that xd.

I think it is better to just always set GDK_BACKEND=x11 for now.

[psadi]

I think it is better to just always set GDK_BACKEND=x11 for now.

Good merge and release ?

[Samueru-sama]

I think it is better to just always set GDK_BACKEND=x11 for now.

Good merge and release ?

I don't think so.

The problem with this solution is that the app doesn't crash instantly, it instead opens a window for a second and then closes.

So the user that had this problem is going to see the window open for a second, close and then finally open again, instead just opening right the first time.

[psadi]

merged with the fallback solution at the moment