-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: source_relative #450
Conversation
adds support for generating the docs in the folder relative to the proto source path. If there are multiple directories containing proto files, adding the option --doc_out=markdown,index.md,source_relative will generate the file index.md under each of the proto directories with the documentation for the files in that directory
Hey @Rossiar thanks for the PR! In general this looks good to me. I ran the tests and examples locally and things look good 👍 Can you document the option in README.md and add an entry to the CHANGELOG.md file? Once that's done, I'll get this merged and cut a new release. |
@pseudomuto all done |
v1.5.0 has been released (docker image will take a little longer). Thanks again for the PR! |
Have you got this to work with |
@kd7lxl can you open a new issue? There are a few examples in #449 (which we can actually close @pseudomuto since I think this PR solved it) to help you debug |
For the benefit of anyone else trying out this plugin with buf who may be unfamiliar with the relationship between the
Note here since If you naively try to specify only the source_relative option like I first did e.g.
you will see The message isn't wrong but it's confusing and could be improved. It would have saved me some time had it given the description in the comment a few lines earlier e.g.
|
adds support for generating the docs in the folder relative to the proto source path. If there are multiple directories containing proto files, adding the option
--doc_out=markdown,index.md,source_relative
will generate the fileindex.md
under each of the proto directories with the documentation for the files in that directory. This PR satisfies #449 and is a very lazy copy of #399, which is simply out of date and I wasn't smart enough to fixup.@pseudomuto it would be great to merge this as the
source_relative
opt is an accepted option for protoc-gen-go and will also allow this plugin to be used nicely with the lovelybuf generate