-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise newlines after module-level docstrings #3932
Merged
JelleZijlstra
merged 5 commits into
psf:main
from
DanielNoord:module_docstring_newlines_rebase
Oct 10, 2023
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
595024b
Standardise newlines after module-level docstrings
DanielNoord b519246
Move tests to ``preview`` directory
DanielNoord 5e04977
Add two more tests
DanielNoord 4901a7e
Merge branch 'main' into module_docstring_newlines_rebase
JelleZijlstra 03b7281
Move tests
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
"""Caching of formatted files with feature-based invalidation.""" | ||
|
||
import hashlib | ||
import os | ||
import pickle | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
""" | ||
Generating lines of code. | ||
""" | ||
|
||
import sys | ||
from dataclasses import replace | ||
from enum import Enum, auto | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
""" | ||
Formatting numeric literals. | ||
""" | ||
|
||
from blib2to3.pytree import Leaf | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
'''''' | ||
|
||
'\'' | ||
'"' | ||
"'" | ||
|
@@ -59,6 +60,7 @@ | |
# output | ||
|
||
"""""" | ||
|
||
"'" | ||
'"' | ||
"'" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
"""Single line module-level docstring should be followed by single newline.""" | ||
|
||
|
||
|
||
|
||
a = 1 | ||
|
||
|
||
"""I'm just a string so should be followed by 2 newlines.""" | ||
|
||
|
||
|
||
|
||
b = 2 | ||
|
||
# output | ||
"""Single line module-level docstring should be followed by single newline.""" | ||
|
||
a = 1 | ||
|
||
|
||
"""I'm just a string so should be followed by 2 newlines.""" | ||
|
||
|
||
b = 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
"""I am a very helpful module docstring. | ||
|
||
Lorem ipsum dolor sit amet, consectetur adipiscing elit, | ||
sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. | ||
Ut enim ad minim veniam, | ||
quis nostrud exercitation ullamco laboris | ||
nisi ut aliquip ex ea commodo consequat. | ||
Duis aute irure dolor in reprehenderit in voluptate | ||
velit esse cillum dolore eu fugiat nulla pariatur. | ||
Excepteur sint occaecat cupidatat non proident, | ||
sunt in culpa qui officia deserunt mollit anim id est laborum. | ||
""" | ||
|
||
|
||
|
||
|
||
a = 1 | ||
|
||
|
||
"""Look at me I'm a docstring... | ||
|
||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
........................................................NOT! | ||
""" | ||
|
||
|
||
|
||
|
||
b = 2 | ||
|
||
# output | ||
"""I am a very helpful module docstring. | ||
|
||
Lorem ipsum dolor sit amet, consectetur adipiscing elit, | ||
sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. | ||
Ut enim ad minim veniam, | ||
quis nostrud exercitation ullamco laboris | ||
nisi ut aliquip ex ea commodo consequat. | ||
Duis aute irure dolor in reprehenderit in voluptate | ||
velit esse cillum dolore eu fugiat nulla pariatur. | ||
Excepteur sint occaecat cupidatat non proident, | ||
sunt in culpa qui officia deserunt mollit anim id est laborum. | ||
""" | ||
|
||
a = 1 | ||
|
||
|
||
"""Look at me I'm a docstring... | ||
|
||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
............................................................ | ||
........................................................NOT! | ||
""" | ||
|
||
|
||
b = 2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll run this test as it's not in
simple_cases/
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the tests to
preview/
to make sure they run under preview mode. They executed now withpytest -k module_docstring
.Also added another two tests cases of which I thought the original PR didn't really have a good test: