Fix broken state #197
Merged
Fix broken state #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rofl0r this not not to discourage you. A new PR which adds your change back with a fix for Makefiles would still be welcome. |
bucanero
approved these changes
Apr 16, 2024
|
wow, this went down quick. @sharkwouter: any other issue than the one that only affected gnu make in a configuration that was previously not working (build.mak + C++) ? i held off on filing the required toolchain update so far since the other thread is still waiting for a comment from @davidgfnet - but maybe i should just go ahead anyway. |
|
I think you can propose a solution either with a PR or a discussion here: https://github.com/pspdev/pspdev/discussions We do want a solution which does not break existing code, which might be a bit hard to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isystem change seems to be causing issues and we still don't have a fix after 2 weeks. So my suggestion is to revert it for now.