Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add view components for rendering google scholar meta tags for scraping. #104

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Add view components for rendering google scholar meta tags for scraping. #104

merged 4 commits into from
Oct 31, 2022

Conversation

ajkiessl
Copy link
Contributor

@ajkiessl ajkiessl commented Oct 28, 2022 •
edited
Loading

closes #103

@ajkiessl ajkiessl marked this pull request as ready for review October 28, 2022 20:19
banukutlu
banukutlu reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just one minor comment

spec/component/google_scholar_metadata_component_spec.rb Outdated Show resolved Hide resolved
@ajkiessl ajkiessl merged commit 450ffb9 into main Oct 31, 2022
@ajkiessl ajkiessl deleted the 103-scholar-meta-tags branch October 31, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banukutlu banukutlu banukutlu left review comments

@Smullz622 Smullz622 Awaiting requested review from Smullz622

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta tags for Google Scholar
2 participants
@ajkiessl @banukutlu