Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grad School Auto Mailers #796

Closed
jlandiseigsti opened this issue Jun 21, 2024 · 1 comment · Fixed by #813
Closed

Update Grad School Auto Mailers #796

jlandiseigsti opened this issue Jun 21, 2024 · 1 comment · Fixed by #813
Assignees

Comments

@jlandiseigsti
Copy link
Contributor

jlandiseigsti commented Jun 21, 2024

AC
The grad school was under the impression that emails were being automatically sent to students when their format reviews were rejected or accepted. They would like this to be the case, like it currently is for honors and sset.

Also they have language changes, some major and some minor, to just about all the autoreply emails.

TECH NOTES
Currently the logic for this exists on workflow_mailer.rb, lines 14/25, in which calling format_review_rejected/accepted raises an Exception is raised unless the partner is sset or honors. Additionally, see format_review_update_service lines 28/34, which only call the mailer method if the partner is sset or honors.

We will need to update the tests on workflow_mailer_spec.rb

@jlandiseigsti jlandiseigsti converted this from a draft issue Jun 21, 2024
@jlandiseigsti jlandiseigsti self-assigned this Jun 21, 2024
@jlandiseigsti jlandiseigsti moved this from Next Sprint to In progress in ETDA Workflow Jul 11, 2024
@jlandiseigsti
Copy link
Contributor Author

@jlandiseigsti jlandiseigsti changed the title Send Format Review Reject/Accept Emails from Grad Update Grad School Auto Mailers Jul 31, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done (In QA for Review) in ETDA Workflow Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Deployed to Production
Development

Successfully merging a pull request may close this issue.

1 participant