796 format accepted mailers grad #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format-review accept and reject mailers had logic to not send unless the partner was sset or honors. This change adds graduate school to the list.
Updates the text of the graduate school mailers and the tests accordingly.
ajkiessl
requested changes
Aug 1, 2024
db/schema.rb
Outdated
| @@ -301,6 +301,7 @@ | |||
| t.string "lionpath_semester" | |||
| t.string "academic_program" | |||
| t.string "degree_checkout_status" | |||
| t.datetime "author_release_warning_sent_at" | |||
There was a problem hiding this comment.
Just to be safe, let's remove this.
spec/mailers/workflow_mailer_spec.rb
Outdated
| context "when the current partner is neither 'sset' or 'honors'" do | ||
| it "raises an exception" do | ||
| skip 'not sset nor honors' if current_partner.sset? || current_partner.honors? | ||
| context "when the current partner does not send format_review emails" do |
There was a problem hiding this comment.
This will need the milsch: true tag to make it run in CI.
spec/mailers/workflow_mailer_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| context "when the current partner is neither 'sset' nor 'honors'" do | ||
| context "when the current partner should not send" do |
There was a problem hiding this comment.
This will need the milsch: true tag aswell
796 - updates from code review 796 - updates from code review 796 - updates from code review 796 - updates from code review 796 - updates from code review 796 - updates from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #796
Updates the text of the mailers, and changes the logic so that the grad school has format_approved and format_rejected emails. Also updates tests and correct some test holes that were there.