Login return to #805
Merged
Login return to #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't default to Author. Also, only link committee members to approvers when directing to approver index so the linking doesn't happen whne datatables are loading
… to ensure a post is sent
… valid. Else return_to the root path for that user model.
jlandiseigsti
approved these changes
Jul 2, 2024
| @@ -10,7 +10,15 @@ class AdminController < ApplicationController | |||
|
|
|||
| def set_session | |||
| if current_remote_user.nil? | |||
| session[:return_to] = request.url | |||
| # Its important that the return_to is NOT stored if: | |||
There was a problem hiding this comment.
Appreciate these comments! A nice gift to future us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this ultimately will fix the issue we are seeing with approvers (knock on wood). We were not applying any judgement to the "return_to" urls we were storing for session change/login between user types. This allowed for urls like '/approver.json' to be stored. I actually adapted some code from Scholarsphere to add some discretion to what we store. I still do not know exactly why a .json request was being used to login. Perhaps when azure resets a session it just takes the last request? If a user left their browser open to our approvers page for a while, then went to reload, this might've been triggered and the .json request was used?