866 alert banner #868
Merged
866 alert banner #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the config gem for an alert that can be created with changes to a YAML file.
ajkiessl
requested changes
Nov 13, 2024
| @@ -0,0 +1,7 @@ | |||
| <div class="announcement container-fluid <%= Settings.announcement&.html_class || "yoo doggie" %>"> | |||
There was a problem hiding this comment.
Is the OR operator needed here? It can just be nil if html_class is not defined.
There was a problem hiding this comment.
Ha ha, absolutely not necessary. Glad you caught this.
Yes, my plan was to inject the yml from config like in catalog. Planning to try this out in the QA environment.
ajkiessl
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #866
Uses the config gem for an alert that can be created with changes to a YAML file.