user login #983
Merged
user login #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banukutlu
reviewed
Apr 6, 2022
banukutlu
reviewed
Apr 6, 2022
banukutlu
reviewed
Apr 6, 2022
banukutlu
reviewed
Apr 6, 2022
banukutlu
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
LGTM 🎉 tested on the preview, works nicely. great job @whereismyjetpack 👏🏻 thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
Adds ability to support penn state users as well as guest users, right now logins aren't intended for general public use, so we've hidden the 'login' behind a
/loginroute. once logged in, we pull user email, and groups from our oauth-proxy, we can use this information to allow admins to do adminy things in the future. right now it drives weather or not mini-profiler is shownTo use locally, we have to set the HTTP header
X_AUTH_REQUEST_EMAILin our browser. I'm using mod-headers for testingWe might want to, eventually, support a
/logoutroute, and maybe in the future wrap things likebookmarksin aif current_userblock? I'm thinking out loud on those.As another PR, I may want to code up an /admin interface, where we can maybe do things like set banners, index records, etc.