Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces coveralls with code climate #206

Merged
merged 2 commits into from
May 26, 2020
Merged

Replaces coveralls with code climate #206

merged 2 commits into from
May 26, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented May 21, 2020

additionally I removed a gem called ruby-debug because it kept giving this error below and I didn't think we used it anyway:

➜  psulib_traject git:(codeclimate) ✗ bundle exec rake
jruby: warning: unknown property jruby.cext.enabled
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.util.SecurityHelper to field java.lang.reflect.Field.modifiers
WARNING: Please consider reporting this to the maintainers of org.jruby.util.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
sBundler could not find compatible versions for gem "linecache":
  In snapshot (Gemfile.lock):
    linecache (= 1.3.1)

  In Gemfile:
    ruby-debug java was resolved to 0.10.6, which depends on
      linecache (~> 1.3.1) java

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

@cdmo cdmo added this to the 0.4.x HathiTrust Integration milestone May 21, 2020
@cdmo cdmo requested a review from banukutlu May 21, 2020 23:11
@cdmo cdmo self-assigned this May 21, 2020
Gemfile Show resolved Hide resolved
README.md Show resolved Hide resolved
@banukutlu
Copy link
Contributor

banukutlu commented May 22, 2020

guess you got hathi_overlaps/overlap_all_unique.csv mistakenly in with this PR?

Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase :)

@cdmo cdmo requested a review from banukutlu May 22, 2020 17:46
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and looks great but the travis build fails - seems an easy change

@cdmo cdmo requested a review from banukutlu May 23, 2020 04:10
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@banukutlu banukutlu merged commit 32bd325 into master May 26, 2020
@banukutlu banukutlu deleted the codeclimate branch May 26, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants