Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hathi online #209

Merged
merged 17 commits into from
Jun 4, 2020
Merged

Hathi online #209

merged 17 commits into from
Jun 4, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Jun 2, 2020 •
edited
Loading

#204

  • Need to look at how the csv constant is populated, maybe use config gem?
  • Need to run an extract and see how this performs, I am right now

Additional changes

  • trims whitespace off of 001 for id field
  • updates "soft depredations" in traject
  • updates custom_spec.rb to fix some problems in the organization of the specs
  • loosens requirements on and updates Traject gem
  • added /spec filter for simplecov
  • ran rubocop auto fix after deleting part of the rubocop todo

@cdmo cdmo self-assigned this Jun 2, 2020
@cdmo cdmo marked this pull request as ready for review June 3, 2020 02:56
@cdmo cdmo requested a review from banukutlu June 3, 2020 02:56
@cdmo
Finishes up spec by streamlining config a bit and adding hathi stuff …
d372ee4 
…to that config, plus a new config for `test` environment
@cdmo
Copy link
Contributor Author

cdmo commented Jun 4, 2020

btw I did test this on local and it didn't have any noticeable impact on records per second. just under a 1,000 on my mac

banukutlu
banukutlu suggested changes Jun 4, 2020
View reviewed changes
spec/lib/traject/macros/custom_spec.rb Outdated Show resolved Hide resolved
banukutlu
banukutlu approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @cdmo

@banukutlu banukutlu merged commit b41f53b into master Jun 4, 2020
@banukutlu banukutlu deleted the hathi-online branch June 4, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banukutlu banukutlu banukutlu approved these changes

Assignees

@cdmo cdmo

Labels
None yet
Projects
None yet
Milestone
0.4.x HathiTrust and Bento Integration
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmo @banukutlu