Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: enhance reliability of receiving EDF files at the end of an experiment #9

Merged
merged 9 commits into from
Jun 17, 2024

Conversation

mh105
Copy link
Contributor

@mh105 mh105 commented Jun 14, 2024

This PR contains

  • a BF to unregister ioHub keyboard monitor of escape and space releases as discussed here.
  • ENH commits to make receiving EDF files at the end of an experiment more reliable. Specifically, dependent on the merge of this PR into the main psychopy release, the current PR will use the exposed PsychoPy filename when dsfile is None to open and download EDF files with the same naming convention as the rest of subject data files. If the saving folder does not exist, we also mkdir to make sure we do save the eye tracking data.
  • BF around dependency of SR research package sr-research-pylink from their own PyPI server.

@mh105
Copy link
Contributor Author

mh105 commented Jun 15, 2024

Apparently the PsychoPy plugin environment manager is quite general as shown here. But this generic formulation is notably a problem in this situation with a non-PyPI index for installing a dependency of the plugin. Perhaps you just have to use an if statement to handle this edge case! I'll leave that to the development team to decide how to handle...

@TEParsons TEParsons merged commit 7853885 into psychopy:main Jun 17, 2024
1 of 3 checks passed
@TEParsons
Copy link
Collaborator

I think the solution is going to be us pestering the eyelink team to put their package on PyPi :P

I've pulled this in - @mh105 would you mind checking with the latest psychopy/dev and main branch of this repo installed whether your eyelink is now found and calibrates correctly? If so, I'll queue up a release of this plugin to coincide with the next release of PsychoPy and all these fixes can be live :D

@mh105
Copy link
Contributor Author

mh105 commented Jun 17, 2024

In order for some of my commits to work correctly, I need the merge of this PR into the PsychoPy release and then into dev: psychopy/psychopy#6555

@mh105
Copy link
Contributor Author

mh105 commented Jun 19, 2024

@TEParsons Just a gentle reminder to see if you could merge my other PR into PsychoPy release and dev branches so I can test out whether my EyeLink can be imported correctly using the new importlib approach. Thanks!

@mh105
Copy link
Contributor Author

mh105 commented Jun 24, 2024

I've tested them - didn't work initially but after psychopy/psychopy#6610 and #10, they work smoothly now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants