-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel: Reorder, fixes, certbot with --nginx #100
panel: Reorder, fixes, certbot with --nginx #100
Conversation
…installer into pterodactyl-1.0
@vilhelmprytz A thing to say is that when using |
Yes, I see your point. I remember I mentioned I was going to implement certbot |
A bit late I would say. I have a solution. We can do the review threw discord and quickly go threw all of the stuff that I have done. It would be really hard for me to split this PR. |
…installer into master-panel-PR
…installer into master-panel-PR
…r into master-panel-PR
related to #100 (comment)
…r into master-panel-PR
Co-authored-by: Vilhelm Prytz <[email protected]>
Co-authored-by: Vilhelm Prytz <[email protected]>
Also sorry for taking so long before properly reviewing your PR. When you move a lot of the functions around in conjunction with all the changes, it makes it harder for me to review in one go. 🙂 I think we're closing in on a merge now. I've got to test the script using Let's Encrypt before merge (after all review change requests are resolved). |
Ok all OS are tested now. |
When executed, the exit status of a function is the exit status of the last command executed in the body. Since the expression would return exit 1, the function ask_assume_ssl would cause the script to exit if the user selected not to ASSUME_SSL (the expression is the last command of the function).
vagrant centos images do not have /usr/local/bin in their path so we make sure it is always present
same problem as with 2c9e366
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Big reorder, added more dividers, made code simpler to read, changed up the order a bit, remade
perform_install
, remade OS specific installs, removed redundantapt update
, removed unused variables, added--nginx
instead of--standalone
, removed a lot of redundant checks for OS version (if it checks if OS is the correct and that it is supported against a hard coded list, we don't need to recheck that every time we run something).Fixes #88