This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Feature/use config #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be expanded for other settings but the only pertinent one was the port at the moment. |
DaneEveritt
reviewed
Mar 16, 2019
DaneEveritt
reviewed
Mar 16, 2019
DaneEveritt
reviewed
Mar 16, 2019
main.go
Outdated
| logger.Get().Infow("using config daemon port", zap.String("port", strconv.Itoa(int(confPort)))) | ||
| bindPort = int(confPort) | ||
| // default to the bindPort default from the flag section | ||
| logger.Get().Debugw("could not find sftp port, falling back to \"2022\"", zap.Error(err))111 |
There was a problem hiding this comment.
Whats the 111 at the end for?
DaneEveritt
suggested changes
Mar 16, 2019
|
@DaneEveritt I got fat hands man... Plus the 1 key is next to the arrows on my laptop for some reason... |
DaneEveritt
approved these changes
Mar 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to get the sftp-server to use the port configured in the daemon config if a port was not set via flag.