-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ES module for Node.js #962
Conversation
This reverts commit eee1a36.
@pubkey Can you review please? |
Please do not check in generated files from the dist folder. This makes the PR unreadable. |
@pubkey Done |
Hmm, the CI fails. |
@pubkey Probably need to increase this constant: broadcast-channel/test/integration.test.js Lines 550 to 551 in c872596
Should I fix this to make CI pass? |
Yes please. |
1ee4f8b
to
c14f3a6
Compare
c14f3a6
to
12e6479
Compare
Merged and released. |
Issue:
Can't import
broadcast-channel
as ES module for Node.js.Steps to reproduce: create simple project with
index.mjs
(having just 1 line with import of broadcast-channel) and try to runnode index.mjs
Solution:
.mjs
extensions for ESM module. (Don't addtype: "module" in package.json
because we want to support both ESM and CJS)More details here: https://github.com/sheremet-va/dual-packaging