FIX #125 temporaryDocument throws when setting field to null

pubkey · Jul 11, 2017 · c2a5878 · c2a5878
1 parent 969bc6d
commit c2a5878
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/RxDocument.js b/src/RxDocument.js
@@ -187,6 +187,8 @@ class RxDocument {
     }
 
     _defineGetterSetter(valueObj, objPath = '') {
+        if (valueObj === null) return;
+
         let pathProperties = this.collection.schema.getSchemaByObjectPath(objPath);
         if (pathProperties.properties) pathProperties = pathProperties.properties;
 

diff --git a/test/unit/TemporaryDocument.test.js b/test/unit/TemporaryDocument.test.js
@@ -34,7 +34,7 @@ describe('TemporaryDocument.test.js', () => {
             assert.equal(newDoc.firstName, 'foobar');
             c.database.destroy();
         });
-        it('should be possible to set the primary', async()=>{
+        it('should be possible to set the primary', async() => {
             const c = await humansCollection.createPrimary(0);
             const newDoc = c.newDocument();
             newDoc.passportId = 'foobar';
@@ -120,4 +120,16 @@ describe('TemporaryDocument.test.js', () => {
             c.database.destroy();
         });
     });
+    describe('ISSUES', () => {
+        describe('#215 setting field to null throws', () => {
+            it('reproduce', async() => {
+                const c = await humansCollection.create(0);
+                const newDoc = c.newDocument();
+                newDoc.age = null;
+                newDoc.age = 10;
+                assert.equal(newDoc.age, 10);
+                c.database.destroy();
+            });
+        });
+    });
 });