Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection change events corrupt keys containing square brackets when key compression is enabled #5605

Closed
adam-lynch opened this issue Feb 7, 2024 · 3 comments
Closed

Collection change events corrupt keys containing square brackets when key compression is enabled #5605

adam-lynch opened this issue Feb 7, 2024 · 3 comments

Comments

@adam-lynch
Copy link
Contributor

We have a tags object on documents. When adding a key like "[example]", the key is "" in the collection change event, but only when key compression is enabled.

Test here: #5603

This is particularly bad for us because bad values are being sent to our server and when our client catches up with the server, it overwrites the good values with bad. So for users, they add a tag, it's fine, then it disappears.
@adam-lynch adam-lynch mentioned this issue Feb 7, 2024
Closed
4 tasks
@pubkey pubkey reopened this Feb 7, 2024
@pubkey
Copy link
Owner

pubkey commented Feb 7, 2024

This was an error in the key-compression package, fixed in this commit: pubkey/jsonschema-key-compression@7ab31e0

@pubkey pubkey mentioned this issue Feb 7, 2024
Merged
pubkey added a commit that referenced this issue Feb 7, 2024
@pubkey
Bugfix/issue #5605 corrupt keys containing square bracket (#5607)
23fad4d 
* FIX #5603 key-compressed collection change events when object key is added containing square brackets

* ADD changelog

* FIX lint
@pubkey
Copy link
Owner

pubkey commented Feb 11, 2024

Should be fixed in the latest releases. Ping me if it still does not work.

@pubkey pubkey closed this as completed Feb 11, 2024
@adam-lynch
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-lynch @pubkey