ADD ability to use server as a part of bigger Express app #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
A NEW FEATURE
Describe the problem you have without this PR
Closes #1448
Adds ability tu use server as a part of bigger express app.
It's achieved by adding new option for db.server named
startServerwhich is default set totrue(to be backwards compatible). WhenstartServeris set tofalseonly express app is returned which allows to mount server as a part of bigger express app.req.basUrl check was also modified to support different mount points.
Todos
As I wrote in feature request I will be offline for up to two weeks. I will fix all comments and add docs/update changelog when I will be back online.