Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preCreateRxCollection #1534

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

yanshiyason
Copy link
Contributor

fix #1533

This PR contains:

  • IMPROVED typings

Describe the problem you have without this PR

When creating a plugin using typescript, the hooks property doesn't contain the type for preCreateRxCollection function.

@yanshiyason yanshiyason force-pushed the add_pre_create_rx_collection branch from 8005a14 to cbd8e78 Compare October 1, 2019 01:20
@yanshiyason yanshiyason force-pushed the add_pre_create_rx_collection branch from cbd8e78 to f73c0e0 Compare October 1, 2019 01:22
@pubkey pubkey merged commit eeb814d into pubkey:master Oct 1, 2019
@pubkey
Copy link
Owner

pubkey commented Oct 1, 2019

Great catch. Merged.

@yanshiyason yanshiyason deleted the add_pre_create_rx_collection branch October 1, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preCreateRxCollection missing in rx-plugin.d.ts
2 participants