Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2471 multiple invocations of subscription after upsertLocal() #2474

Closed
wants to merge 2 commits into from

Conversation

styx0r
Copy link

@styx0r styx0r commented Aug 28, 2020

This PR contains:

IMPROVED TESTS revealing a potential bug

Describe the problem you have without this PR

Issue #2471:

  • when upsert a localDocument subscriptions invoked twice
  • the implemented test additionally revealed that subscribing with
    .$.subscribe on a document it is directly invoked already,
    not sure whether this is intended

Todos

  • Tests
  • Changelog
  • Bugfix

@pubkey
Copy link
Owner

pubkey commented Aug 31, 2020

Thanks for adding the test. Can you fix the linting so that the CI runs the tests and does not stop before?

resolved no-shadowed-variable linting error
@styx0r
Copy link
Author

styx0r commented Aug 31, 2020

Thanks for adding the test. Can you fix the linting so that the CI runs the tests and does not stop before?

Yes sorry, I did not recognise this by myself. Now it failed exactly at the newly implemented test.

@pubkey
Copy link
Owner

pubkey commented Sep 22, 2020

Fixed at 2cf425f
Thank you for adding the test, this really helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants