add new option autoStart. #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could be set to `false` to avoid initialReplication on replicateRxCollection(). default to true to avoid breaking change.
In this case, the first run() starts the polling loop.
It was always false positive as changing liveInterval to >0 had no effect, and that is the purpose of the tests. Now, we insert document, that triggers a push and we get a proof properly.
… first non-local write.
pubkey
reviewed
Apr 27, 2022
|
Merged, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
replicateRxCollection()provides a way to configure the way to replicate a given collection.However, by default, this function also run an initial replication as side effect.
IMHO, it's a matter of separation of concerns:
The moment to configure collections and replications is not always the same we get ready to do the first replication.
I would like to trigger replications collection by collection and keep control on the order, the timing... and separately from the replication definition.
I suggest to add an option to prevent the default first replication and separate the replication configuration and triggering.
This PR adds new option
runInitialReplication.It could be set to false to avoid
initialReplicationonreplicateRxCollection().default to
trueto avoid breaking changePlease consider this PR as a draft and support for discussions.
I know this issue is an opinionated one, feel free to challenge it ;)