report bug : data still there despite remove and destroy calls

[mmouterde]

• A BUGFIX

data still there despite remove and destroy calls

[pubkey]

destroy destroys the javascript object, it will not remove the data. I know that this is a bad naming, maybe we should change that in the future.

remove however should really remove the data.

Both, remove and destroy assume that the collection/database is no longer used. Your second query after the remove will likely return data from the query cache, so it makes you think that the data is still there.
We could add a check to every function call to check if the db/collection is already destroyed, but this would add to much overhead I think.

[mmouterde]

Ok thanks for these precisions.

So my test can not be probant this way.

As mentionned on Gitter, my initial trouble comes from my indexedDB that still has documents once db.remove() and db.destroy() and col.remove() and `col.destroy() have been called.

[pubkey]

I tried to reproduce the problem with this test, but it didn't have any error.

/**
                 * @link https://github.com/pubkey/rxdb/pull/3788
                 */
                it('#3788 removing the collection should also remove all changes', async () => {
                    if (!config.storage.hasMultiInstance) {
                        return;
                    }

                    const dbName = randomCouchString();

                    const createDb = async () => {
                        const db = await createRxDatabase({
                            name: dbName,
                            storage: config.storage.getStorage(),
                            ignoreDuplicate: true
                        });
                        await db.addCollections({
                            human: { schema: schemas.human }
                        });
                        return db;
                    }

                    const db1 = await createDb();
                    await db1.collections.human.insert(schemaObjects.simpleHuman());
                    const db2 = await createDb();

                    // remove the collection on one database
                    await db1.human.remove();


                    /**
                     * Getting the changes in the other database should have an empty result.
                     */
                    const changesResult = await db2.human.storageInstance.getChangedDocumentsSince(10);

                    console.dir(changesResult);

                    assert.strictEqual(changesResult.length, 0);

                    db1.destroy();
                    db2.destroy();
                });

[mmouterde]

Also linked to dash in names 427e226#diff-e3288a7097a47ea2904142245c2895726f20a7be84914f4f4bb889b2adc4148bR589

[pubkey]

Closing this PR. Fixed in ca6ea15