Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

may return undefined if array is empty #4011

Merged
merged 3 commits into from
Oct 9, 2022
Merged

may return undefined if array is empty #4011

merged 3 commits into from
Oct 9, 2022

Conversation

AlexErrant
Copy link
Contributor

@AlexErrant
Copy link
Contributor Author

Apologies for the back and forth - clearly I can't figure out how to run tests locally :|

@pubkey
Copy link
Owner

pubkey commented Oct 8, 2022

No problem. I mostly use the ensureNotFalsy() method for the tuntime checks, maybe that will make it easier to read.

@pubkey pubkey merged commit 869a353 into pubkey:master Oct 9, 2022
pubkey added a commit that referenced this pull request Oct 9, 2022
@pubkey
ADD(changelog) #4011
8359e03
@AlexErrant AlexErrant deleted the typefix branch October 11, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexErrant @pubkey