Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of eventReduce option in documentation #4614

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

russelldavis
Copy link
Contributor

This PR contains:

  • Improved docs

Describe the problem you have without this PR

The actual default value in the code is false, but docs had it as true

@pubkey
Copy link
Owner

pubkey commented Apr 12, 2023

The default should be true, let me check.
EDIT: Yes you are right, the default is false.

pubkey added a commit that referenced this pull request Apr 12, 2023
@pubkey pubkey merged commit e53c5a1 into pubkey:master Apr 12, 2023
@pubkey
Copy link
Owner

pubkey commented Apr 12, 2023

I added a todo so this will be changed in the next major version as it should have been before.
Thank you for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants