-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operation name graphql #5418
Operation name graphql #5418
Conversation
3afcbdf
to
addf0f8
Compare
Hi @jwallet |
I can remove the changes made to the helper functions to make it non
breaking, but it looks like these functions does not follow the required
graphql recommandations found in apollo or hotchocolate documentation
OperationName can stay an optional param
…On Fri., Dec. 22, 2023, 8:28 a.m. Daniel Meyer, ***@***.***> wrote:
Hi @jwallet <https://github.com/jwallet>
Do you think this is a breaking change?
—
Reply to this email directly, view it on GitHub
<#5418 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQEZMICJC6TZYC43P2NI4DYKWDGXAVCNFSM6AAAAABA7CULCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGY4DSMRZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I changed the helper functions queryBuilderFromRxSchema to prevent a breaking change with the pullStream. |
Also, if someone uses a query like the one below, he can just ignore the "operationName" param, but the operationName must match the name after query/mutation keyword, and if after the merge no one provide an operationName, it will just stay like before the merge since the param is optional. query($checkpoint: CheckpointInput, $limit: Int!)
{
collectionFeedForRxDBReplication(checkpoint: $checkpoint, limit: $limit) {
collection {
documents {
id
name
age
updatedAt
deleted
}
checkpoint {
id
updatedAt
}
}
}
} |
Thank you, merged. |
This PR contains:
breaking the helper functionDescribe the problem you have without this PR
GraphQL
operationName
is required with some tools to valid the gQL requestWe used
patch-package
to change this inrxdb
but we will like to be able to upgrade without it.