fix: always use slice() for applying offset and limit in loki storage instance, fixing the fuzzing test run #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance, fixing the fuzzing test run
…ance, fixing the fuzzing test run
Connum
force-pushed
the
fix/lokijs-fuzzing
branch
from
0daa350 to
8e8a0e5
Compare
|
Hi. The changes look good. Can you add one test to the query-correctness tests which contains the broken fuzzed query+documents combination? |
|
Sure! I'm currently trying to track down another loki related bug, then I'll add the test for this one. |
…nto fix/lokijs-fuzzing
…ance, fixing the fuzzing test run
Connum
force-pushed
the
fix/lokijs-fuzzing
branch
from
252521f to
cca6c1f
Compare
|
Test has been added and verified that it fails before the fix and passes after. |
|
I guess the failing example-graphq jobl must have been a hiccup during |
|
Yes I will just retry the CI until it works. |
pubkey
added a commit
that referenced
this pull request
Mar 12, 2024
|
Merged. Thank you for that great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
This PR contains:
A BUGFIX
Describe the problem you have without this PR
The fuzzy testing failed for the LokiJS storage, because sometimes there were less documents returned than expected. After quite some investigation, I found
limit()andoffset()to be the culprits, so instead of using those, slice() is now always used for limit and offset values, just as it already was whenmustRunMatcherwastrue.Todos