fix race condition in test case leading to sporadic fails #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connum
force-pushed
the
fix/testcase-race
branch
from
82b42b9 to
32a25f1
Compare
pubkey
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
The reason for the stability test "many writes while replication" sporadically failing was actually a race condition in the test itself.
Sometimes the fork instance was written to first, which then lead to a write conflict. This could theoretically happen with any storage adapter, but those less performant (which loki and denokv seem to be) were more prone to hit that case.
By using
promiseSeries(), it's now made sure that the master instance is written to first.