RxState.property$ should emit stable reference #6462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsequent subscription pubkey#6459
|
Ah, I understand the problem now with your rerenders. Working on a fix.. |
|
Thank you! There's no rush for me, the previous version works perfectly fine. If it's helpful, I could create a version of the react example which uses |
kilbot
changed the title
No you do not have to. The unit test is enough and your example would anyway not be in the CI test suite. |
pubkey
added a commit
that referenced
this pull request
Oct 6, 2024
pubkey
added a commit
that referenced
this pull request
Oct 6, 2024
|
Fixed here #6463 |
pubkey
added a commit
that referenced
this pull request
Oct 6, 2024
* FIX RxState.property$ should emit stable reference #6462 * ADD changelog * FIX typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows a failing test for RxState.property$ not being strictly equal for initial and subsequent subscriptions. I believe RxDocument gets around this issue by using an internal property cache.
This PR contains:
IMPROVED TESTS
Describe the problem you have without this PR
#6459
Todos