Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to pass graphql-ws options into the replication options #6598

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

epodgaysky
Copy link
Contributor

This PR contains:

  • IMPROVED typings
  • A NEW FEATURE

In our project we need more flexibility with replication subscription, particularly we want it to try reconnecting until the connection is established, even if server is not responding.

@pubkey
Copy link
Owner

pubkey commented Nov 18, 2024

Hi @epodgaysky
The changes look good. We need at least one test and this should be added to the docs.

@epodgaysky
Copy link
Contributor Author

@pubkey lmk if there's anything else I need to add

@epodgaysky epodgaysky requested a review from pubkey November 19, 2024 12:02
@pubkey pubkey merged commit 2dfff79 into pubkey:master Nov 20, 2024
21 checks passed
pubkey added a commit that referenced this pull request Nov 20, 2024
@pubkey
Copy link
Owner

pubkey commented Nov 20, 2024

Thank you @epodgaysky merged!

Copy link
Owner

@pubkey pubkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants