Feat: Rate limiting #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds query rate limiting based on IP addresses.
DNS Queries
Use
--query-rate-limit <query-rate-limit>to rate limit dns queries per second based on IP addresses. It is disabled by default. This is a general limit not depending on the query being forwarded or hitting the internal cache. It limits ICANN queries and PKD queries.Use
--query-rate-limit-burst <query-rate-limit-burst>to allow short term burst above the general query-rate-limit.For reference: Google's
8.8.8.8seems to have a 1,500 queries per second rate limit per IP address too including a higher short term burst.DHT queries
Use
--dht-rate-limit <dht-rate-limit>to rate limit DHT request based on IP addresses. Default: 5. Only direct DHT hits count. Cached DHT request do not count to this limit.Use
--dht-rate-limit-burst <dht-rate-limit-burst>to allow short term burst above the general dht-rate-limit. Default: 25The DHT rate limit has been added to protect excessive DHT requests. The chosen default values are best guesses and err on the low end.