ActiveRecord::Base.serialize signature changed when ActiveRecord >= 7.1

[azhaizhai]

ActiveRecord::Base.serialize changed the signature in 7.1.0beta1 https://github.com/rails/rails/blob/7-1-stable/activerecord/CHANGELOG.md

Here is no longer compatibility in rails 7.1.0+

public_activity/lib/public_activity/orm/active_record/activity.rb

Line 42 in de9383d

serialize :parameters, Hash unless %i[json jsonb hstore].include?(columns_hash['parameters'].type)

Maybe we can change it to

if Rails.version >= '7.1.0'
  serialize :parameters, type: Hash unless %i[json jsonb hstore].include?(columns_hash['parameters'].type)
else
  serialize :parameters,  Hash unless %i[json jsonb hstore].include?(columns_hash['parameters'].type)
end

[ur5us]

@azhaizhai Technically Rails 7.1 still support the old signature, s. https://github.com/rails/rails/blob/v7.1.2/activerecord/lib/active_record/attribute_methods/serialization.rb#L183

def serialize(attr_name, class_name_or_coder = nil, coder: nil, type: Object, yaml: {}, **options)

The incompatibility with Rails 7.1 stems from a different issue, i.e. the lack of a default coder which is the breaking change. Going forward, we will explicitly define a coder.

Closing this in favor of #382.