Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change var keyword to let or const #1253

Closed
5 tasks
Achele opened this issue Oct 27, 2022 · 5 comments · Fixed by #1259
Closed
5 tasks

Change var keyword to let or const #1253

Achele opened this issue Oct 27, 2022 · 5 comments · Fixed by #1259

Comments

@Achele
Copy link
Contributor

Achele commented Oct 27, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file Gruntfile.js in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-108  var coverageReports = grunt.file.expand("coverage/*/coverage.txt");
+108  const coverageReports = grunt.file.expand("coverage/*/coverage.txt");

-109  var reports = {};
+109  let reports = {};

-110  var report; var i; var len;
+110. let report; let i; let len;
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@Achele
Copy link
Contributor Author

Achele commented Oct 27, 2022

@TildaDares I created this FTO for first timers who are still looking for an issue to resolve. Please do check it out.

@TildaDares
Copy link
Member

Amazing work @Achele. Thank you!

@TildaDares
Copy link
Member

Reserved for @lizwe-mac for 24 hours!

@boluwatifee
Copy link
Contributor

Hi, @TildaDares, is this issue still available?

@abba-danmusa
Copy link

Hi @TildaDares, I want to contribute but I can see that this issue is reserved for someone. If there are any open issues I'd like to resolve some.
Thank you.

TildaDares added a commit that referenced this issue Nov 2, 2022
Changed var keyword to let or const #1253
vanithaak pushed a commit to vanithaak/Leaflet.DistortableImage that referenced this issue Nov 5, 2022
vanithaak pushed a commit to vanithaak/Leaflet.DistortableImage that referenced this issue Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants